Your grandfather was promoted to Brigadier General in 1916 and then promoted to Major General in 1918
so this date this photo between 196-1918
The pattern of tunic he wear in this photo is either the pattern 1912 or the late war 1918 pattern
khaki Service dress jacket. You can see the rank of Brigadier Gen by the cross baton/sabre on this shoulder. He also wears red collar tabs or scarlet gorgets with gold embroidered oak leaves.
He would have had plain cuffs, no ranks. He would have worn this with a Sam Brown belt.
A Sam Brown is a thick brown leather waistbelt, with a smaller cross strap belt which was worn over the right shoulder. Most high ranking officers worn riding breeches, and tall leather boots with spurs.
As small bio for those interested
He was educated at the University of Bishop's College, and became a general contractor. He enlisted in the Canadian Militia as a private in 1886; in 1914 he was given command of the 13th Battalion, Canadian Expeditionary Force. He was promoted brigadier-general in 1916, and in 1918 Major-General, commanding the Third Canadian Division. He was awarded the DSO in 1915 (bar in 1918), as well as several foreign decorations; he was created a Commander of the Order of St. Michael and St. George in 1917, and a KCB in 1919. He retired to civilian life in 1919, and he died in Montreal on 15 February 1937.